[Tech Debt] Fix dynamic table tests #1085
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
| @@ -103,6 +95,9 @@ def setup(self, project, my_dynamic_table): | |||
| # the tests touch these files, store their contents in memory | |||
| initial_model = get_model_file(project, my_dynamic_table) | |||
|
|
|||
| # verify the initial settings are correct in Snowflake | |||
| self.check_start_state(project, my_dynamic_table) | |||
There was a problem hiding this comment.
This used to be commented at the beginning of every test. It was moved here and will run automatically. So it looks like the comment was removed from each test, but it as effectively just uncommented.
| """ | ||
| See above about the two commented assertions. In the meantime, these have been validated manually. | ||
| """ | ||
| # self.check_start_state(adapter, my_dynamic_table) |
There was a problem hiding this comment.
It looks like this was deleted, but it was just uncommented. See my GH comment on line 99. This is true of all lines like this, but I'm leaving one comment for the sake of brevity.
| self.change_config_via_alter(project, my_dynamic_table) | ||
| _, logs = run_dbt_and_capture(["--debug", "run", "--models", my_dynamic_table.name]) | ||
|
|
||
| # self.check_state_alter_change_is_applied(adapter, my_dynamic_table) | ||
| # verify the updated settings are correct in Snowflake | ||
| self.check_state_alter_change_is_applied(project, my_dynamic_table) |
There was a problem hiding this comment.
We're now checking in the database to verify the settings were applied. Even though that is a stronger check than checking the logs, we still want to check the logs so that we know how the change was made. If a change that was supposed to be applied via an alter is actually applied via a drop/create, that's not passing.
resolves #1084
Problem
We were manually running some integration tests.
Solution
Update the tests so that they could run automatically.
Checklist