Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry to reduce flakiness of TestSecrets #1083

Merged
merged 2 commits into from
Jun 14, 2024
Merged

add retry to reduce flakiness of TestSecrets #1083

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426eff3
add retry to reduce flakiness of TestSecrets
colin-rogers-dbt Jun 14, 2024
deb3ad3
Merge branch 'main' into addRetryToSecretsTest
colin-rogers-dbt Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/functional/adapter/test_python_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ class TestSecrets:
def models(self):
return {"secret_python_model.py": SECRETS_MODE}

# This test can be flaky because of delays in the integration being set up before trying to use it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is doing thesee tests one at a time still not getting them all out of flakiness?

@pytest.fixture(scope="class")
def profiles_config_update(self):
return {"retry_all": True, "connect_retries": 3}

def test_secrets(self, project):
project.run_sql(
"create or replace secret test_secret type = generic_string secret_string='secret value';"
Expand Down
Loading