Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip with reason dynamic table tests with reference to PR. #1080

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Skip with reason dynamic table tests with reference to PR. #1080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/functional/adapter/dynamic_table_tests/test_dynamic_tables_changes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
query_warehouse,
)

DT_SKIP_MESSAGE = "Dynamic tables are known to be broken in v1.6; see https://github.com/dbt-labs/dbt-snowflake/issues/1016; see https://github.com/dbt-labs/dbt-snowflake/pull/1049 for fix. Backports were determined only to be done for versions 1.7+. Users should therefore upgrade to v1.7+ for the fix."


class SnowflakeDynamicTableChanges:
@staticmethod
Expand Down Expand Up @@ -122,6 +124,7 @@ def test_full_refresh_occurs_with_changes(self, project, my_dynamic_table):
assert_message_in_logs(f"Applying REPLACE to: {my_dynamic_table}", logs)


@pytest.mark.skip(reason=DT_SKIP_MESSAGE)
class TestSnowflakeDynamicTableChangesApply(SnowflakeDynamicTableChanges):
@pytest.fixture(scope="class")
def project_config_update(self):
Expand Down Expand Up @@ -171,6 +174,7 @@ def test_change_is_applied_via_replace(self, project, adapter, my_dynamic_table)
assert_message_in_logs(f"Applying REPLACE to: {my_dynamic_table}", logs)


@pytest.mark.skip(reason=DT_SKIP_MESSAGE)
class TestSnowflakeDynamicTableChangesContinue(SnowflakeDynamicTableChanges):
@pytest.fixture(scope="class")
def project_config_update(self):
Expand Down Expand Up @@ -213,6 +217,7 @@ def test_change_is_not_applied_via_replace(self, project, adapter, my_dynamic_ta
assert_message_in_logs(f"Applying REPLACE to: {my_dynamic_table}", logs, False)


@pytest.mark.skip(reason=DT_SKIP_MESSAGE)
class TestSnowflakeDynamicTableChangesFailMixin(SnowflakeDynamicTableChanges):
@pytest.fixture(scope="class")
def project_config_update(self):
Expand Down
Loading