quoting config not working with 1.8 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do this in two spots, so this line would also need updating. |
…on, update macros to have condtion to check based on type
mikealfare
reviewed
Jun 7, 2024
| schema_relation = {"database": database, "schema": schema} | ||
| kwargs = {"schema_relation": schema_relation} | ||
| schema_relation = SnowflakeRelation.create(database=database, schema=schema) | ||
| kwargs = {"schema_relation": schema_relation.render()} |
There was a problem hiding this comment.
Is there a reason to render here? Are we testing if the macro can take a relation object or a string (or both I suppose)?
There was a problem hiding this comment.
you can't pass a proper python object to run-operation AFAIK so this is an easy workaround
tests/functional/adapter/list_relations_tests/test_special_characters.py
Outdated
Show resolved
Hide resolved
colin-rogers-dbt
approved these changes
Jun 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* revert change for quoting policy issue * make revet in both places * update format to ignore identifier name * update test to use SnowflakeRelation and render out the schema_relation, update macros to have condtion to check based on type * remove unneeded comments from updating test * add test based on quoting schema names * update name to more generic my_model (cherry picked from commit 57285d5)
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Jun 10, 2024
* quoting config not working with 1.8 (#1075) * revert change for quoting policy issue * make revet in both places * update format to ignore identifier name * update test to use SnowflakeRelation and render out the schema_relation, update macros to have condtion to check based on type * remove unneeded comments from updating test * add test based on quoting schema names * update name to more generic my_model (cherry picked from commit 57285d5) * local pre-commit run --------- Co-authored-by: Matthew McKnight <[email protected]> Co-authored-by: McKnight-42 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1074
docs dbt-labs/docs.getdbt.com/#
Problem
During decoupling work we updated some naming conventions in some macros that seem to go around quotiing_policy, reverting to put us back in good standing.
Solution
revert to using
schema_relationwhere able in theadapters.sqlif schema_relation is a string, otherwise useschema_relation.include(indentifier=False)tests/functional/adapter/list_relations_tests/test_pagination.pyupdate tests in
tests/functional/adapter/list_relations_tests/test_pagination.pyto use aSnowflakeRelationobject instead of adictadd a new test based of the edgecase from issue.
Todo:
Checklist