-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Update list_relations_without_caching
to support Snowflake bundle 2024_03
#1049
Conversation
…s, and dynamic tables all show up correctly
… or without the is_dynamic field to support optional install of bundle 2024_03
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
I will need to manually run this against Snowflake with the bundle on/off (depending on whether it's currently enabled). I will attach that run after getting feedback (so I don't need to do it multiple times). |
The original run (Latest#1) on this PR tested against an enabled bundle. The second run of integration tests (Latest#2) tested against a disabled bundle. You can see both runs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about some of the conditional logic. Elaboration of cases should articulate if this order is correct or not.
… returning a large number of tuples and encapsulate the result to relation intention of this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your thorough explanations and the added comments. I concur with your approach, although I personally find no qualms with moving the quote policy into the main parse function. If nothing else, that field could be just an argument and part of the signature. So for me the finished outcome is great!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-1049-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5da6fdbfd0895cf86c49dd2b95d89d3d2a57aa70
# Push it to GitHub
git push --set-upstream origin backport-1049-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1049-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5da6fdbfd0895cf86c49dd2b95d89d3d2a57aa70
# Push it to GitHub
git push --set-upstream origin backport-1049-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-1049-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5da6fdbfd0895cf86c49dd2b95d89d3d2a57aa70
# Push it to GitHub
git push --set-upstream origin backport-1049-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
resolves #1016
Problem
Snowflake introduced an optional bundle
2024_03
which will shortly become mandatory. This bundle changes a few things:dynamic_table
inshow terse objects
andshow objects
, they now show up as tablesshow objects
(but notshow terse objects
) calledis_dynamic
that can be used to differentiate tables and dynamic tablesSolution
list_relations_without_caching
macro, check to see if there is anis_dynamic
fieldis_dynamic
Checklist