Allow enabling/disabling stats collection on catalog table using env var #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
aranke
force-pushed
the
catalog_enable_stats
branch
from
34b3aad to
361d196
Compare
| @@ -37,6 +37,8 @@ | |||
|
|
|||
|
|
|||
| {% macro snowflake__get_catalog_tables_sql(information_schema) -%} | |||
| {%- set enable_stats = env_var('DBT_CATALOG_TABLE_ENABLE_STATS', 'true') == 'true' -%} | |||
There was a problem hiding this comment.
Is there precedent for using an env_var this way in macros? I suspect the Adapters team might want us to have an official flag for this.
|
@aranke @peterallenwebb Thanks for the productive investigation here! Following on this afternoon's conversation, we're going to investigate the possibility of decomposing table-level and column-level metadata/stats into two separate queries. If we decide we want that behavior to be conditional, it should be via first-class flag (CLI option / env var). In the meantime, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're consuming a lot of memory populating the
statsfields incatalog, since we have 1 record per column ininformation_schema.Solution
Allow disabling collection of the
statsfields frominformation_schemato save memory.On ad-hoc testing with my personal schema in Snowflake, this has resulted in a 20% memory decrease (690 MB → 550 MB).
Checklist