Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test_anonymous_usage_stats.py #1029

Merged
merged 3 commits into from
May 15, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented May 8, 2024

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

this 1.7.latest dbt core pr dbt-labs/dbt-core#9998 causes test failures for dbt-snowflake on 1.7 failing run: https://github.com/dbt-labs/dbt-snowflake/actions/runs/9004106060 due to change in referencing profiles_config_update and config option to project_config_update and the flags option instead

Solution

Make the appropriate changes in the test classes which will also make them more similar to 1.8 and above.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this May 8, 2024
@cla-bot cla-bot bot added the cla:yes label May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label May 9, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 489dbe8 into 1.7.latest May 15, 2024
31 of 33 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the mcknight/fix-anonyomous-usage-test branch May 15, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants