Skip to content

Commit

Permalink
edit comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
VersusFacit committed Nov 6, 2024
1 parent 2570641 commit a5b39df
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
3 changes: 0 additions & 3 deletions dbt/include/snowflake/macros/adapters.sql
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@
{% endmacro %}

{% macro snowflake__list_relations_without_caching(schema_relation, max_iter=10, max_results_per_iter=10000) %}
{# -- Use query_pre_hook for optional configurations prior to fetching relations. For sake of
-- consistent use, place ;s in the query_pre_hook definition, not this macro. #}

{%- set max_total_results = max_results_per_iter * max_iter -%}
{%- set sql -%}
{% if schema_relation is string %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,13 @@ def models(self):
return {"my_model.sql": _MODEL_ICEBERG}

def test_quoting_ignore_flag_doesnt_break_iceberg_metadata(self, project):
"""We inject the QUOTED_IDENTIFIERS_IGNORE_CASE into the underlying query that fetches
objects which will fail without proper normalization within the python function after
the list relations macro returns."""
"""https://github.com/dbt-labs/dbt-snowflake/issues/1227
The list relations function involves a metadata sub-query. Regardless of
QUOTED_IDENTIFIERS_IGNORE_CASE, this function will fail without proper
normalization within the encapsulating python function after the macro invocation
returns. This test verifies that normalization is working.
"""
run_dbt(["run"])

self.list_relations_without_caching(project)

0 comments on commit a5b39df

Please sign in to comment.