Support custom grain in DSI callsites #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
WilliamDee
force-pushed
the
will/support-custom-grain
branch
from
dc47c31 to
e20b045
Compare
courtneyholcomb
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Left a couple comments but otherwise looks good!
Since this is a breaking change, I would wait to merge it until you're ready to bump the version (otherwise can risk someone else doing a patch version bump that includes your change). This should be a minor version bump.
@DevonFulcher also has a breaking change PR up. Maybe you guys can coordinate releasing & updating core. Make sure you guys sync with me before you update core because there are some extra steps you'll need to take.
dbt_semantic_interfaces/parsing/where_filter/parameter_set_factory.py
Outdated
Show resolved
Hide resolved
…WhereFilterIntersection.filter_expression_parameter_sets from property to a method that takes in the valid custom grain names
…nticWhereFilterIntersection.filter_expression_parameter_sets
WilliamDee
force-pushed
the
will/support-custom-grain
branch
from
8b3303a to
7c59d74
Compare
WilliamDee
added a commit
to dbt-labs/metricflow
that referenced
this pull request
Dec 5, 2024
## Context We merged 2 breaking changes in DSI dbt-labs/dbt-semantic-interfaces#363 and dbt-labs/dbt-semantic-interfaces#365 which changed most spec typing that used time granularity to be a `str` instead of `TimeGranularity` to enable support for custom granularity. Similarly, there were additional breaking changes to the objects that requires passing in `custom_granularity_names`. This PR updates all those callsites to be compatible with the new version of DSI (to be released) Resolves SL-3097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given that custom granularity is available, we need to start supporting it when parsing through names and filters.
Non-breaking changes
WhereFilterTimeDimensionFactoryas it's not used anywhere (MetricFlow has it's own in metricflow-semantics)Breaking changes
DunderedNameFormatterin favour ofStructuredDunderedNameas it's duplicate logiccustom_granularity_namestoStructuredDunderedName.parse_nameas a parameter to parse out any custom grainPydanticWhereFilter.call_parameter_setsandPydanticWhereFilterIntersection.filter_expression_parameter_setsfrom a property to a method that takes in the valid custom grain namesChecklist
changie newto create a changelog entryResolves SL-2989