Add validations for time spines #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
courtneyholcomb
force-pushed
the
court/custom-cal-validations
branch
from
783f1e3 to
f4fcf3e
Compare
courtneyholcomb
force-pushed
the
court/custom-cal-validations
branch
from
f4fcf3e to
e6e1eb8
Compare
courtneyholcomb
force-pushed
the
court/custom-cal-validations
branch
from
e6e1eb8 to
bf14e8a
Compare
courtneyholcomb
force-pushed
the
court/custom-cal-validations
branch
from
514bd38 to
71754db
Compare
courtneyholcomb
requested review from
plypaul,
WilliamDee and
theyostalservice
courtneyholcomb
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
WilliamDee
reviewed
Sep 26, 2024
| primary_column=PydanticTimeSpinePrimaryColumn(name="ds", time_granularity=TimeGranularity.DAY), | ||
| custom_granularities=[ | ||
| PydanticTimeSpineCustomGranularityColumn(name="retail_year"), | ||
| PydanticTimeSpineCustomGranularityColumn(name="quarter"), # todo |
There was a problem hiding this comment.
Is something blocking this validation? Seems like its not in this PR
There was a problem hiding this comment.
whoops I just forgot to remove the comment! It is validated here!
There was a problem hiding this comment.
it's the "names cannot match reserved time granularity keywords" one
There was a problem hiding this comment.
ooo didn't realize it was already in the code inside check_valid_name and that was done prior to this PR
WilliamDee
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validations for time spines.
Also bumps to a new production version. This new version of DSI will need to be released to mantle before custom calendar is released as a feature.
Checklist
changie newto create a changelog entry