Add exports config to YAML spec for saved queries #190
Conversation
| @@ -18,3 +18,6 @@ test: | |||
|
|
|||
| lint: | |||
| hatch run dev-env:pre-commit run --show-diff-on-failure --color=always --all-files | |||
|
|
|||
| json_schema: | |||
There was a problem hiding this comment.
This make target was mentioned in CI, but it didn't actually exist in the repo so I added it.
|
|
||
| @property | ||
| @abstractmethod | ||
| def schema_name(self) -> Optional[str]: |
There was a problem hiding this comment.
@QMalcolm the core parser can take schema from yaml and convert it to schema_name just as we do with Pydantic here, correct? I'm assuming that's the case.
There was a problem hiding this comment.
That is indeed the case. We have a separate unparsed and parsed node representation. It'll be schema in the unparsed and schema_name in the parsed
| assert export2_config.schema_name is None | ||
| assert export2_config.alias is None |
There was a problem hiding this comment.
Question for the folks who designed the spec - do we want to allow this? It seems like we can't actually fulfill this contract because there's no way to tell a warehouse "here, put this data..... someplace."
There was a problem hiding this comment.
Note - if this will be caught by a validation PR I haven't read yet, just tell me to go away. :)
There was a problem hiding this comment.
What about the table name? Or is the table name the export name? Is that obvious to people?
There was a problem hiding this comment.
Yep it will default to the export name. I have no idea if that's obvious to people but it should be in the docs when we get to that
Resolves #189
Description
Adds
exportsYAML options to the spec forsaved_queries.Checklist
changie newto create a changelog entry