Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exceptions on invalid entity names in filter and group by expressions #170

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tlento
Copy link
Collaborator

@tlento tlento commented Oct 10, 2023

The previous logic was simply calling an error string formatting function,
and one which would return an incorrect error message at that. This raises
an exception with an entity-specific name formatting error message.

@cla-bot cla-bot bot added the cla:yes label Oct 10, 2023
Copy link
Collaborator Author

tlento commented Oct 10, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

…ssions

The previous logic was simply calling an error string formatting function,
and one which would return an incorrect error message at that. This raises
an exception with an entity-specific name formatting error message.
@tlento tlento linked an issue Oct 10, 2023 that may be closed by this pull request
2 tasks
@tlento tlento force-pushed the throw-errors-on-invalid-entity-names branch from 579a5ce to fb8e8e9 Compare October 10, 2023 04:18
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OHHHH I see! Good catch 🚀

@tlento tlento merged commit 1af06d7 into main Oct 10, 2023
9 checks passed
@tlento tlento deleted the throw-errors-on-invalid-entity-names branch October 10, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Invalid entity names in filter and group by expressions do not raise an error
2 participants