Update valid name regex to disallow dunders #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMalcolm
added
Backport 0.2.latest
tlento
reviewed
Sep 14, 2023
tlento
approved these changes
Sep 14, 2023
QMalcolm
force-pushed
the
qmalcolm--149-disallow-dunders-in-names
branch
from
5580474 to
877afd4
Compare
4 tasks
QMalcolm
added a commit
that referenced
this pull request
Sep 18, 2023
…unders-in-object-names [BACKPORT 0.2.latest] Disallow dunders in object names (#150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
Description
We use dunders
__to separate named objects in a single string reference. I.e.orders__is_large_orderwhereorderis the primary entity andis_large_orderis the dimension name. If people use dunders in their names, then this logic breaks. This PR updates the regex for name validity checking to disallow dunders.Checklist
changie newto create a changelog entry