Address comments.

dbt-labs · Sep 18, 2023 · 961e4ab · 961e4ab
1 parent 5e75b16
commit 961e4ab
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/dbt_semantic_interfaces/implementations/saved_query.py b/dbt_semantic_interfaces/implementations/saved_query.py
@@ -25,7 +25,7 @@ def _implements_protocol(self) -> SavedQuery:
 
     name: str
     metrics: List[str]
-    group_bys: List[str]
+    group_bys: List[str] = []
     where: List[PydanticWhereFilter] = []
 
     description: Optional[str] = None

diff --git a/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json b/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json
@@ -420,6 +420,10 @@
                     "type": "array"
                 }
             },
+            "required": [
+                "name",
+                "metrics"
+            ],
             "type": "object"
         },
         "semantic_model_defaults_schema": {

diff --git a/dbt_semantic_interfaces/parsing/schemas.py b/dbt_semantic_interfaces/parsing/schemas.py
@@ -288,6 +288,7 @@
             "items": {"type": "string"},
         },
     },
+    "required": ["name", "metrics"],
     "additionalProperties": False,
 }
 

diff --git a/dbt_semantic_interfaces/protocols/semantic_manifest.py b/dbt_semantic_interfaces/protocols/semantic_manifest.py
@@ -27,11 +27,7 @@ def project_configuration(self) -> ProjectConfiguration:  # noqa: D
 
     @property
     def saved_queries(self) -> Sequence[SavedQuery]:  # noqa: D
-        """Saved queries defined in the manifest.
-
-        Returns a default value for backward compatibility until the next breaking release.
-        """
-        return ()
+        pass
 
 
 SemanticManifestT = TypeVar("SemanticManifestT", bound=SemanticManifest)
-Original file line number
+Diff line change
@@ Expand Up / @@ -288,6 +288,7 @@ @@
                 "items": {"type": "string"},
             },
         },
+        "required": ["name", "metrics"],
         "additionalProperties": False,
     }
@@ Expand Down @@