-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable custom granularity inputs for filters
We are enabling support for custom granularity, which means users will need to be able to reference them in where filters and other contexts where their input representations of their manifest elements will need to be parsed. Historically, we have restricted time granularities to an enumerated set of standard supported grains. With the addition of custom granularities we must now admit the possibility of arbitrary string names representing valid time granularities. This change updates the interfaces for parsing time dimensions out of filter expressions to allow for arbitrary string inputs representing custom granularity names. For various reasons - mainly having to do with the filter parser not having access to the semantic manifest - we will NOT be able to support custom granularity references via dundered string names. So something like `metric_time__martian_year` will not work, but the explicit syntax of `Dimension('metric_time').grain('martian_year')` will be accepted and processed.
- Loading branch information
Showing
8 changed files
with
58 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Allow filter parameters to accept custom granularities | ||
time: 2024-09-08T22:17:57.865557-07:00 | ||
custom: | ||
Author: tlento | ||
Issue: "345" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters