Remove existence checks in _validate_top_level_objects as the lists…

… are guaranteed
dbt-labs · Oct 25, 2023 · 4e1c5be · 4e1c5be
1 parent 96eb8d9
commit 4e1c5be
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/dbt_semantic_interfaces/validations/unique_valid_name.py b/dbt_semantic_interfaces/validations/unique_valid_name.py
@@ -201,24 +201,17 @@ def _validate_top_level_objects(semantic_manifest: SemanticManifest) -> List[Val
         """Checks names of objects that are not nested."""
         issues: List[ValidationIssue] = []
 
-        if semantic_manifest.semantic_models:
-            issues.extend(
-                UniqueAndValidNameRule._validate_top_level_objects_of_type(
-                    semantic_manifest.semantic_models, "semantic model"
-                )
+        issues.extend(
+            UniqueAndValidNameRule._validate_top_level_objects_of_type(
+                semantic_manifest.semantic_models, "semantic model"
             )
+        )
 
-        if semantic_manifest.metrics:
-            issues.extend(
-                UniqueAndValidNameRule._validate_top_level_objects_of_type(semantic_manifest.metrics, "metric")
-            )
+        issues.extend(UniqueAndValidNameRule._validate_top_level_objects_of_type(semantic_manifest.metrics, "metric"))
 
-        if semantic_manifest.saved_queries:
-            issues.extend(
-                UniqueAndValidNameRule._validate_top_level_objects_of_type(
-                    semantic_manifest.saved_queries, "saved query"
-                )
-            )
+        issues.extend(
+            UniqueAndValidNameRule._validate_top_level_objects_of_type(semantic_manifest.saved_queries, "saved query")
+        )
 
         return issues