Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #646

Closed
wants to merge 20 commits into from
Closed

Test #646

wants to merge 20 commits into from

Conversation

colin-rogers-dbt
Copy link
Contributor

  • Support Privilege Grants to Roles and Groups in Materialization
  • Support Privilege Grants to Roles and Groups in Materialization
  • rectified code with pre-commit
  • Update CI workflow to include new env vars
  • Add fixture to create grants/roles for test purposes
  • Fixed ImportError related to misnaming BaseModelGrantsRedshift
  • Remove debugging comment
  • Change away from inheritance of BaseGrants
  • clean up duplicate tests
  • Split model grants tests into view and table tests
  • Renamed model view and model table test suites
  • added groups and roles to env-setup
  • fix pre-commit EOF space

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@soksamnanglim
Copy link
Contributor

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this May 6, 2024
@mikealfare mikealfare deleted the extendGrantPrivilege branch July 17, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants