Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialized Views not updating cache #69

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Materialized Views not updating cache #69

merged 2 commits into from
Apr 24, 2024

Conversation

McKnight-42
Copy link
Contributor

…amtable type and test that we do the create and drop instead, and remove a unneeded semi colon

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

We do not appear to be updating cache for MV functionality like drops, renames, adds which is causing catalog mismatch errors in runs especially between MV's that are dependent on each other

Solution

Current:
we will remove materialized_view from the renameable_relation variable thus reverting us to the create and drop functionality that we were seeing before the introduction in dbt-labs/dbt-core#9682

Attempted:
Update our various macros to either use commonly used Python functions from the base impl.py such as drop_relation, and rename_relation or use the more primitive version designed in the base adapter e.g cache_dropped and cache_renamed to ensure we are maintaining parity with database expectation.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

…amtable type and test that we do the create and drop instead, and remove a unneeded semi colon
@McKnight-42 McKnight-42 self-assigned this Apr 23, 2024
@McKnight-42 McKnight-42 requested a review from mikealfare April 23, 2024 23:15
@McKnight-42 McKnight-42 merged commit 3f0091c into main Apr 24, 2024
17 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/127 branch April 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants