Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook tests #153

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Fix hook tests #153

merged 5 commits into from
Oct 1, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 1, 2024

Problem

Tests are failing because on-run-* hooks are written to run_results.json after dbt-labs/dbt-core#10699

Solution

Change expected run results to 3 and expected statuses to pass or success.

Similar change in dbt-core: https://github.com/dbt-labs/dbt-core/pull/10699/files#diff-9d1dba53313b9eaf718de40090eff09f3436521000699f6f1d586de556bdd037R477-R479

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@aranke aranke marked this pull request as ready for review October 1, 2024 17:42
@aranke aranke requested a review from a team as a code owner October 1, 2024 17:42
@mikealfare mikealfare merged commit cb4a953 into main Oct 1, 2024
21 checks passed
@mikealfare mikealfare deleted the fix_hook_tests branch October 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants