Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify hatch setup #126

Merged
merged 10 commits into from
Jul 16, 2024
Merged

Simplify hatch setup #126

merged 10 commits into from
Jul 16, 2024

Conversation

mikealfare
Copy link
Contributor

resolves dbt-labs/dbt-adapters#164

Problem

The hatch implementation was over-engineered.

Solution

Collapse the hatch environments down to one dev (default) environment. Reflect the updates in the contributing guide.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 13, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 13, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@mikealfare mikealfare marked this pull request as ready for review July 16, 2024 20:43
@mikealfare mikealfare requested a review from a team as a code owner July 16, 2024 20:43
@mikealfare mikealfare enabled auto-merge (squash) July 16, 2024 22:21
@mikealfare mikealfare merged commit 66ba1c2 into main Jul 16, 2024
21 checks passed
@mikealfare mikealfare deleted the hatch-env-work branch July 16, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contributors guide for hatch
2 participants