-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point testing dependencies to main
#12
Conversation
# Conflicts: # tests/unit/test_adapter.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases added here are being migrated back to dbt-postgres
(for now). It was determined that the issue was likely being caused by a combination of not looking at main
for internal dependencies and not instantiating the invocation context variables before checking them. set_invocation_context({})
is run on line 338 now, right before getting the catalog, and tests are now passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies were moved down into the hatch environments, in alignment with dbt-adapters
. This was done for a combination of reasons:
- we cannot publish a package to PyPI with dependencies installed from GitHub, so development versions of internal packages would need to be identified as hatch environment dependencies
- there is not a lot of value in installing dev and test tooling without the development versions of internal packages
- having just the tooling as installable extras in the production distribution is confusing
features = ["dev", "test"] | ||
dependencies = [ | ||
# TODO: remove `dbt-core` dependencies from unit tests | ||
"dbt-core @ git+https://github.com/dbt-labs/dbt-core.git#subdirectory=core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda surprised we don't need dbt-tests-adapter for unit tests
All testing dependencies should point to main to ensure that the latest changes are reflected.
default
environment the dev version of all production dependenciesdefault
environment for non-detached hatch environments (typechecking and testing)Checklist