Clarify and improve controls of latest_version for version commands
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
approved these changes
May 7, 2024
There was a problem hiding this comment.
@dave-connors-3 This is a really well crafted PR. I appreciate the considerate inclusion of the --incremental flag, which both preserves existing flags/docs, and provides the current functionality in the new flag. The use of enums and dicts is both necessary and sufficient for making this all work.
I have one minor non-blocking comment about an unnecessary tracing comment.
Otherwise, this should be good to go. Thanks for putting this together.
dbt_meshify/main.py
Outdated
Comment on lines
393
to
397
| if latest and increment: | ||
| raise FatalMeshifyException( | ||
| "Cannot specify both --latest and --prerelease. Please choose one or the other." | ||
| ) | ||
|
|
dbt_meshify/utilities/versioner.py
Outdated
Comment on lines
20
to
26
| class LatestVersionBehavior(str, Enum): | ||
| """An operation describes the type of work being performed.""" | ||
|
|
||
| Prerelease = "prerelease" | ||
| Increment = "increment" | ||
| Latest = "latest" | ||
|
|
|
|
||
| # import ipdb; ipdb.set_trace() | ||
|
|
||
| new_latest_version_number = latest_version_number_map[latest_version_behavior] |
There was a problem hiding this comment.
This is really clever. Great use of enums and dicts.
dave-connors-3
commented
May 7, 2024
dave-connors-3
commented
May 7, 2024
dave-connors-3
commented
May 7, 2024
Co-authored-by: Nicholas A. Yager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #199
This PR improves the ergonomics of determining which version of a model should be marked as the
latest_versionwhen using thedbt-meshify versionanddbt-meshify operation bump-versioncommands.This PR does not change the default behavior:
Old behavior:
--latestflag increments thelatest_versionby oneNew Behavior:
-
--increment(new flag!) increments thelatest_versionby one--latestflag -- makes the newest, greatest integer'd version thelatest_version, per @dbeatty10 's example in the issue.