Fix: The group command will check for existing group file paths.
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-connors-3
approved these changes
Jan 16, 2024
dbt_meshify/dbt_projects.py
Outdated
| paths: Dict[Path, int] = {} | ||
| for group in self.manifest.groups.values(): | ||
| path = self.path / Path(group.original_file_path) | ||
| paths[path] = paths.get(path, 0) + 1 |
dbt_meshify/dbt_projects.py
Outdated
| path = self.path / Path(group.original_file_path) | ||
| paths[path] = paths.get(path, 0) + 1 | ||
|
|
||
| self._group_definition_files = list( |
There was a problem hiding this comment.
just want to make sure i follow this logic -- you're sorting the paths by the count of groups defined in that path, and only returning a list of paths?
There was a problem hiding this comment.
Yep. Looking at it now, however, I realize that sorting actually isn't necessary, since it should error out if len(x) > 1. I can pull this out to free up a few milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
There was a small defect in
dbt-meshify, in which the tool would ignore existing files that define groups, instead always defaulting to_group.yml. The desired behavior would be to default to a single file that already contains groups if one exists. To that end, I've implemented a check that finds all files that define groups, and if there is one and only one, it will default to that file. If there are none, it will use_groups.yml. If there are multiple, it will raise a fatal error and prompt the user to provide a--group-file-yamlpath.Along the way, I also added tests to confirm that the functionality works as expected.
Resolves: #188