-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake: Add expression parameter to columns #275
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ad0fded
Add email domain column to snowflake_external.yml and update create_e…
kyleburke-meq d247cea
Merge branch 'main' into main
dataders 547bc7f
Merge branch 'main' into main
dataders 439cf1b
Merge branch 'main' into main
dataders 7e5b2f9
Update integration_tests/models/plugins/snowflake/snowflake_external.yml
dataders 9173c20
Update integration_tests/models/plugins/snowflake/snowflake_external.yml
dataders 8017ef7
Merge branch 'main' into main
dataders 00a8f5c
Update snowflake_external.yml to include email_domain column
kyleburke-meq 3471bb0
Merge remote-tracking branch 'origin/main'
kyleburke-meq 19a3349
Add email_domain column to people_expression.sql and snowflake_extern…
kyleburke-meq 100d23e
Update snowflake_external.yml to use people_json_expression instead o…
kyleburke-meq 3590e05
Update snowflake.yml to rename etl timestamp to etl_timestamp
kyleburke-meq 0b04472
Refactor create_external_table.sql in snowflake plugin
kyleburke-meq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
integration_tests/models/plugins/snowflake/people_expression.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
SELECT | ||
{{ dbt_utils.star(from=ref('people')) }}, | ||
split_part(email, '@', 2) as email_domain | ||
FROM {{ ref('people') }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change introduced the bug - #315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a bug. left a reply in that issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually I think I see the issue now. We should be using
column_quoted
instead ofcolumn_alias
here I think?:dbt-external-tables/macros/plugins/snowflake/create_external_table.sql
Line 43 in 4d26c38