Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changelogs #9975

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix changelogs #9975

merged 1 commit into from
Apr 18, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 18, 2024

Problem

Changelogs only accept the Issue yaml tag now but 2 dependency changes had the PR tag. These PRs were opened before #9887 was merged and merged after so they were not caught.

Solution

Swap it for the Issue tag

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner April 18, 2024 13:13
@cla-bot cla-bot bot added the cla:yes label Apr 18, 2024
@emmyoop emmyoop requested a review from gshank April 18, 2024 13:16
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (2edd5b3) to head (a8e272a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9975      +/-   ##
==========================================
+ Coverage   88.12%   88.15%   +0.03%     
==========================================
  Files         180      180              
  Lines       22578    22578              
==========================================
+ Hits        19897    19904       +7     
+ Misses       2681     2674       -7     
Flag Coverage Δ
integration 85.46% <ø> (+0.03%) ⬆️
unit 62.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank merged commit 61727ab into main Apr 18, 2024
64 checks passed
@gshank gshank deleted the er/fix-changelog-issue branch April 18, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants