Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize a number of our unit tests #9972

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Conversation

QMalcolm
Copy link
Contributor

addresses: #9961

Problem

Our unit tests are currently in files that don’t match the modules they are testing and are in a flat directory structure.

Solution

Fully addresses:

  • tests/unit/test_yaml_renderer.py
  • tests/unit/test_tracking
  • tests/unit/test_sql_result.py
  • tests/unit/test_semantic_models.py
  • tests/unit/test_selector_errors.py

Partially addresses:

  • tests/unit/test_unit_test_parser.py

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Apr 17, 2024
@QMalcolm QMalcolm requested a review from a team as a code owner April 17, 2024 22:25
@cla-bot cla-bot bot added the cla:yes label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (668fe78) to head (667db08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9972      +/-   ##
==========================================
+ Coverage   80.53%   88.17%   +7.63%     
==========================================
  Files         180      180              
  Lines       22578    22578              
==========================================
+ Hits        18184    19908    +1724     
+ Misses       4394     2670    -1724     
Flag Coverage Δ
integration 85.55% <ø> (+5.01%) ⬆️
unit 62.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm changed the title Qmalcolm 9961 reorganize tests Reorganize a number of our unit tests Apr 18, 2024
@QMalcolm QMalcolm merged commit 1e4bed0 into main Apr 24, 2024
66 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--9961-reorganize-tests branch April 24, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants