Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change agate upper bound to v1.10 #9948

Merged
merged 6 commits into from
May 1, 2024

Conversation

mjkanji
Copy link
Contributor

@mjkanji mjkanji commented Apr 15, 2024

resolves #9934

Problem

The latest version of Agate (1.9.1 at the time of writing) is currently not supported. As described in #9934, this prevents using conda-forge to install for the latest versions of dbt-core.

Solution

This PR increases the upper-bound for agate to v1.10.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@mjkanji mjkanji requested a review from a team as a code owner April 15, 2024 16:27
Copy link

cla-bot bot commented Apr 15, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @mjkanji

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Apr 15, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 15, 2024
@mjkanji mjkanji mentioned this pull request Apr 24, 2024
3 tasks
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (2e3c6fe) to head (8aff9e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9948      +/-   ##
==========================================
- Coverage   88.19%   83.98%   -4.21%     
==========================================
  Files         181      181              
  Lines       22700    22702       +2     
==========================================
- Hits        20020    19067     -953     
- Misses       2680     3635     +955     
Flag Coverage Δ
integration 83.98% <ø> (-1.60%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10
Copy link
Contributor

Thanks for opening this PR @mjkanji !

@emmyoop and I took a look at this, and we realized that we'd need to loosen the upper bound within dbt-common first, and then we can re-run the CI tests (after you merge the latest code from main).

@emmyoop is going to check with the rest of the team internally before we loosen that upper pin in dbt-common.

@mjkanji
Copy link
Contributor Author

mjkanji commented Apr 28, 2024

Thanks for opening this PR @mjkanji !

@emmyoop and I took a look at this, and we realized that we'd need to loosen the upper bound within dbt-common first, and then we can re-run the CI tests (after you merge the latest code from main).

@emmyoop is going to check with the rest of the team internally before we loosen that upper pin in dbt-common.

Hi Doug,

Thank you for the reply. Let me know what the next steps are; should I wait for your review of dbt-common or should I merge the latest changes from main immediately?

@dbeatty10
Copy link
Contributor

Thank you for the reply. Let me know what the next steps are; should I wait for your review of dbt-common or should I merge the latest changes from main immediately?

Go ahead and merge the latest changes from main as soon as you are able.

Separately, I'll check with @emmyoop tomorrow about dbt-common.

@dbeatty10
Copy link
Contributor

@emmyoop opened the associated PR for dbt-common (dbt-labs/dbt-common#119), so that part is taken care of.

@dbeatty10
Copy link
Contributor

@mjkanji we're going to try including this in our release candidate for dbt-core v1.8 tomorrow, so @emmyoop is going to make updates directly to this PR.

@emmyoop emmyoop force-pushed the agate-version-update branch from 43f7d4e to e7139f3 Compare May 1, 2024 16:52
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remember to change back branch on dbt-common!

@emmyoop emmyoop merged commit f884eb4 into dbt-labs:main May 1, 2024
56 of 57 checks passed
@mjkanji
Copy link
Contributor Author

mjkanji commented May 2, 2024

@dbeatty10 @emmyoop Thank you so much for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update agate version
4 participants