-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change agate upper bound to v1.10 #9948
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @mjkanji |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9948 +/- ##
==========================================
- Coverage 88.19% 83.98% -4.21%
==========================================
Files 181 181
Lines 22700 22702 +2
==========================================
- Hits 20020 19067 -953
- Misses 2680 3635 +955
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for opening this PR @mjkanji ! @emmyoop and I took a look at this, and we realized that we'd need to loosen the upper bound within dbt-common first, and then we can re-run the CI tests (after you merge the latest code from @emmyoop is going to check with the rest of the team internally before we loosen that upper pin in dbt-common. |
Hi Doug, Thank you for the reply. Let me know what the next steps are; should I wait for your review of dbt-common or should I merge the latest changes from main immediately? |
Go ahead and merge the latest changes from main as soon as you are able. Separately, I'll check with @emmyoop tomorrow about dbt-common. |
@emmyoop opened the associated PR for |
43f7d4e
to
e7139f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, remember to change back branch on dbt-common
!
@dbeatty10 @emmyoop Thank you so much for implementing this! |
resolves #9934
Problem
The latest version of Agate (1.9.1 at the time of writing) is currently not supported. As described in #9934, this prevents using
conda-forge
to install for the latest versions ofdbt-core
.Solution
This PR increases the upper-bound for
agate
to v1.10.Checklist