Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for unit test that depends on ephemeral model #9929

Merged
merged 12 commits into from
Apr 17, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Apr 12, 2024

Add testing for documented workaround to testing a model that depends on an ephemeral model

documentation: https://github.com/dbt-labs/docs.getdbt.com/pull/5281/files#diff-93cd3964ff9d3a505e3620438d7b0594b473f47a26cec74e57d3c24e36df1a24R283

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (86b349f) to head (b718c54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9929      +/-   ##
==========================================
- Coverage   88.17%   88.12%   -0.05%     
==========================================
  Files         180      180              
  Lines       22578    22578              
==========================================
- Hits        19908    19897      -11     
- Misses       2670     2681      +11     
Flag Coverage Δ
integration 85.43% <ø> (-0.13%) ⬇️
unit 62.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk changed the base branch from unit_testing_sql_format to main April 15, 2024 18:55
@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Apr 17, 2024
@MichelleArk MichelleArk marked this pull request as ready for review April 17, 2024 14:00
@MichelleArk MichelleArk requested a review from a team as a code owner April 17, 2024 14:00
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so simple :)

@MichelleArk MichelleArk merged commit 5cb1279 into main Apr 17, 2024
64 checks passed
@MichelleArk MichelleArk deleted the test-ut-input-ephemeral-with-sql-format branch April 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants