Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unwanted dev dependency #9838

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Removing unwanted dev dependency #9838

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0abbc3
Removing unwanted dev dependency
niteshy Mar 31, 2024
503ed9f
updating change log
niteshy Mar 31, 2024
7a2cdb8
Remove duplicate dependency of protobuf in dev-requirements to resolv…
dbeatty10 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Dependencies-20240331-103917.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Dependencies
body: Remove unwanted dependency of protobuf in dev-requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit:
Can we replace the word unwanted with duplicate here. The word unwanted without the context that this dependency is getting pulled in somewhere else makes it sound like we're dropping the dependency completely.

dbeatty10 marked this conversation as resolved.
Show resolved Hide resolved
time: 2024-03-31T10:39:17.432017-07:00
custom:
Author: niteshy
PR: "9838"
dbeatty10 marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ ipdb
mypy==1.4.1
pip-tools
pre-commit
protobuf>=4.0.0,<5.0.0
pytest>=7.4,<8.0
pytest-cov
pytest-csv>=3.0,<4.0
Expand Down