Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix team name #9805

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix team name #9805

merged 3 commits into from
Mar 25, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 22, 2024

resolves OSS-3

Problem

The core group is core-group not core. When GitHub found nothing it gave permission error.

Solution

Use the right id for the team.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner March 22, 2024 19:01
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (8c8c628) to head (d3de87e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9805      +/-   ##
==========================================
+ Coverage   88.04%   88.07%   +0.03%     
==========================================
  Files         178      178              
  Lines       22461    22461              
==========================================
+ Hits        19776    19783       +7     
+ Misses       2685     2678       -7     
Flag Coverage Δ
integration 85.45% <ø> (+0.03%) ⬆️
unit 61.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop merged commit e46eae1 into main Mar 25, 2024
60 checks passed
@emmyoop emmyoop deleted the er/fix-team-name branch March 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants