Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the upload name is unique #9802

Merged
merged 1 commit into from
Mar 22, 2024
Merged

ensure the upload name is unique #9802

merged 1 commit into from
Mar 22, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 22, 2024

resolves #9801

Problem

CI is flaky due to actions/upload-artifact breaking change

Solution

Ensure uniqueness of artifact name

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner March 22, 2024 16:16
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (c6c0c79) to head (35a16fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9802      +/-   ##
==========================================
- Coverage   88.09%   88.02%   -0.07%     
==========================================
  Files         178      178              
  Lines       22461    22461              
==========================================
- Hits        19787    19772      -15     
- Misses       2674     2689      +15     
Flag Coverage Δ
integration 85.41% <ø> (-0.16%) ⬇️
unit 61.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@emmyoop emmyoop merged commit b435e26 into main Mar 22, 2024
59 checks passed
@emmyoop emmyoop deleted the er/fix-upload-errors branch March 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] time collisions on actions/upload-artifact
2 participants