Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move UnitTestDefinition, implement missing resource_class methods #9651

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Feb 23, 2024

resolves #9667

Problem

UnitTestDefinition, which the WritableManifest depends on, was defined within core

Solution

  • Define UnitTestDefinition & and its upstream components in dbt/artifacts
  • A bit of tidying around other resources -- implementing any missing resource_class methods and serializing them appropriately post-move.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (7f9874d) to head (4846c8a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9651      +/-   ##
==========================================
- Coverage   88.00%   87.98%   -0.02%     
==========================================
  Files         176      178       +2     
  Lines       22311    22369      +58     
==========================================
+ Hits        19634    19682      +48     
- Misses       2677     2687      +10     
Flag Coverage Δ
integration 85.43% <100.00%> (-0.16%) ⬇️
unit 62.15% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Feb 26, 2024
@MichelleArk MichelleArk marked this pull request as ready for review February 26, 2024 19:25
@MichelleArk MichelleArk requested a review from a team as a code owner February 26, 2024 19:25
@MichelleArk MichelleArk merged commit 7329143 into main Feb 26, 2024
56 of 57 checks passed
@MichelleArk MichelleArk deleted the artifacts-tidying branch February 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Artifacts] Define UnitTestDefinition resource in dbt/artifacts/resources
2 participants