Enable using the list command on unit tests #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9480 +/- ##
==========================================
+ Coverage 87.90% 87.97% +0.06%
==========================================
Files 164 167 +3
Lines 22076 22160 +84
==========================================
+ Hits 19407 19496 +89
+ Misses 2669 2664 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
reviewed
Jan 29, 2024
MichelleArk
reviewed
Jan 29, 2024
core/dbt/task/list.py
Outdated
| @@ -113,6 +113,8 @@ def generate_selectors(self): | |||
| elif node.resource_type == NodeType.Unit: | |||
| assert isinstance(node, UnitTestDefinition) | |||
| unit_test_selector = ".".join([node.package_name, node.name]) | |||
| if node.version: | |||
There was a problem hiding this comment.
This should be a direct comparison to None to ensure version=0 is handled correctly.
There was a problem hiding this comment.
It might be worth implementing a property on UnitTestDefinition.. maybe versioned_name? and consolidate this logic here + in formatting in test.py: https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/task/test.py#L87-L88
your call!
MichelleArk
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8508
Problem
Users want to be able to list their unit tests.
Solution
Update the list command to handle listing unit tests
Checklist