-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple adapter constraints from core #9054
Merged
peterallenwebb
merged 3 commits into
feature/decouple-adapters-from-core
from
paw/decouple-adapter-constraints
Nov 21, 2023
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
from dataclasses import dataclass, field | ||
from enum import Enum | ||
from typing import Optional, List | ||
|
||
from dbt.common.dataclass_schema import dbtClassMixin | ||
|
||
|
||
class ConstraintType(str, Enum): | ||
check = "check" | ||
not_null = "not_null" | ||
unique = "unique" | ||
primary_key = "primary_key" | ||
foreign_key = "foreign_key" | ||
custom = "custom" | ||
|
||
@classmethod | ||
def is_valid(cls, item) -> bool: | ||
try: | ||
cls(item) | ||
except ValueError: | ||
return False | ||
return True | ||
|
||
|
||
@dataclass | ||
class ColumnLevelConstraint(dbtClassMixin): | ||
type: ConstraintType | ||
name: Optional[str] = None | ||
# expression is a user-provided field that will depend on the constraint type. | ||
# It could be a predicate (check type), or a sequence sql keywords (e.g. unique type), | ||
# so the vague naming of 'expression' is intended to capture this range. | ||
expression: Optional[str] = None | ||
warn_unenforced: bool = ( | ||
True # Warn if constraint cannot be enforced by platform but will be in DDL | ||
) | ||
warn_unsupported: bool = ( | ||
True # Warn if constraint is not supported by the platform and won't be in DDL | ||
) | ||
|
||
|
||
@dataclass | ||
class ModelLevelConstraint(ColumnLevelConstraint): | ||
columns: List[str] = field(default_factory=list) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider constraints a 'contract'? If so we should move it to common/contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichelleArk What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree - common/contracts makes sense as a home for these based on the existing patterns we have in dbt & dbt/adapters. I'm thinking common/contracts/constraints.py