add flag --no-skip-on-failure for command build, run, retry, seed

.changes/unreleased/Features-20231107-132842.yaml

@@ -0,0 +1,6 @@
+kind: Features
+body: add flag --no-skip-on-failure
+time: 2023-11-07T13:28:42.420727773+01:00
+custom:
+  Author: leo-schick
+  Issue: "2142"

core/dbt/cli/main.py

@@ -174,6 +174,7 @@ def cli(ctx, **kwargs):
 @p.export_saved_queries
 @p.full_refresh
 @p.deprecated_include_saved_query
+@p.no_skip_on_failure
 @p.profiles_dir
 @p.project_dir
 @p.resource_type
@@ -541,6 +542,7 @@ def parse(ctx, **kwargs):
 @global_flags
 @p.exclude
 @p.full_refresh
+@p.no_skip_on_failure
 @p.profiles_dir
 @p.project_dir
 @p.empty
@@ -578,6 +580,7 @@ def run(ctx, **kwargs):
 @p.profiles_dir
 @p.vars
 @p.target_path
+@p.no_skip_on_failure
 @p.threads
 @p.full_refresh
 @requires.postflight
@@ -606,6 +609,7 @@ def retry(ctx, **kwargs):
 @global_flags
 @p.exclude
 @p.full_refresh
+@p.no_skip_on_failure
 @p.profiles_dir
 @p.project_dir
 @p.resource_type
@@ -674,6 +678,7 @@ def run_operation(ctx, **kwargs):
 @global_flags
 @p.exclude
 @p.full_refresh
+@p.no_skip_on_failure
 @p.profiles_dir
 @p.project_dir
 @p.select

core/dbt/cli/params.py

@@ -120,6 +120,13 @@
     help="Stop execution on first failure.",
 )
 
+no_skip_on_failure = click.option(
+    "--no-skip-on-failure",
+    envvar="DBT_NO_SKIP_ON_FAILURE",
+    help="Proceed with downstream nodes even if an upstream node fails.",
+    is_flag=True,
+)
+
 favor_state = click.option(
     "--favor-state/--no-favor-state",
     envvar="DBT_FAVOR_STATE",

core/dbt/flags.py

@@ -75,6 +75,7 @@ def get_flag_dict():
         "log_format",
         "version_check",
         "fail_fast",
+        "no_skip_on_failure",
         "send_anonymous_usage_stats",
         "printer_width",
         "indirect_selection",

core/dbt/task/runnable.py

@@ -450,8 +450,10 @@
     ) -> None:
         if self.graph is None:
             raise DbtInternalError("graph is None in _mark_dependent_errors")
-        for dep_node_id in self.graph.get_dependent_nodes(UniqueId(node_id)):
-            self._skipped_children[dep_node_id] = cause
+        no_skip_on_failure = get_flags().NO_SKIP_ON_FAILURE
+        if not no_skip_on_failure:
+            for dep_node_id in self.graph.get_dependent_nodes(UniqueId(node_id)):
+                self._skipped_children[dep_node_id] = cause
 
     def populate_adapter_cache(
         self, adapter, required_schemas: Optional[Set[BaseRelation]] = None

core/dbt/utils.py

@@ -350,6 +350,7 @@ def args_to_dict(args):
             "debug",
             "full_refresh",
             "fail_fast",
+            "no_skip_on_failure",
             "warn_error",
             "single_threaded",
             "log_cache_events",