Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_schema_named macro #8868

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add drop_schema_named macro #8868

merged 2 commits into from
Nov 8, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Oct 17, 2023

resolves #8025

Tested on a couple adapters, there's some variance in api.Relation.create but I think the default will work for most adapters

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (efa6339) 86.35% compared to head (d58e412) 86.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8868      +/-   ##
==========================================
- Coverage   86.35%   86.29%   -0.07%     
==========================================
  Files         177      177              
  Lines       26383    26383              
==========================================
- Hits        22784    22768      -16     
- Misses       3599     3615      +16     
Flag Coverage Δ
integration 83.08% <ø> (-0.15%) ⬇️
unit 64.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graciegoheen graciegoheen added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Oct 19, 2023
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenyuLInx ChenyuLInx merged commit 6871fc4 into main Nov 8, 2023
55 checks passed
@ChenyuLInx ChenyuLInx deleted the addDropSchemaNamed branch November 8, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2784] [Feature] Add macro drop_schema_named as wrapper around adapter.drop_schema
4 participants