Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adapters to include python package logging in dbt logs #8643
Allow adapters to include python package logging in dbt logs #8643
Changes from 12 commits
8be56c8
2b2f169
427b9b3
81dccde
a5d8f4e
28c501b
b960904
a70a0d6
e8f0c42
c5d97c4
f5092b1
b1f880f
969bcfc
1cf2e06
8418518
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 66 in core/dbt/events/adapter_endpoint.py
Codecov / codecov/patch
core/dbt/events/adapter_endpoint.py#L66
Check warning on line 22 in core/dbt/events/event_handler.py
Codecov / codecov/patch
core/dbt/events/event_handler.py#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored some of this code into
core/dbt/events/logger.py
, is it possible to move the contents of this file there for consistency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would create a circular dependency since this depends on eventmgr which depends on logger.py
Check warning on line 46 in core/dbt/events/event_handler.py
Codecov / codecov/patch
core/dbt/events/event_handler.py#L43-L46