-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate ref override #6600
migrate ref override #6600
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple nits.
seeds__seed_2_csv = """a,b | ||
6,2 | ||
12,4 | ||
18,6""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should """
be on a new line to end the file with a new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some issue with that for csv files
@pytest.fixture(scope="class") | ||
def project_config_update(self): | ||
return { | ||
'config-version': 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we should update the black
config to use the defaults of double quotes?
From https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html:
Black prefers double quotes (" and """) over single quotes (' and '''). It will replace the latter with the former as long as it does not result in more backslash escapes than before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an issue in core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this?
dbt-core/.pre-commit-config.yaml
Lines 4 to 5 in f789b25
# TODO: remove global exclusion of tests when testing overhaul is complete | |
exclude: ^(test/|core/dbt/docs/build/) |
#4788
Description
Checklist
changie new
to create a changelog entry