Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate ref override #6600

Merged
merged 3 commits into from
Jan 13, 2023
Merged

migrate ref override #6600

merged 3 commits into from
Jan 13, 2023

Conversation

ChenyuLInx
Copy link
Contributor

#4788

Description

Checklist

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner January 13, 2023 01:16
@cla-bot cla-bot bot added the cla:yes label Jan 13, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner January 13, 2023 01:18
@ChenyuLInx ChenyuLInx requested a review from aranke January 13, 2023 01:18
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple nits.

seeds__seed_2_csv = """a,b
6,2
12,4
18,6"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should """ be on a new line to end the file with a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some issue with that for csv files

@pytest.fixture(scope="class")
def project_config_update(self):
return {
'config-version': 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should update the black config to use the defaults of double quotes?

From https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html:

Black prefers double quotes (" and """) over single quotes (' and '''). It will replace the latter with the former as long as it does not result in more backslash escapes than before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue in core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this?

# TODO: remove global exclusion of tests when testing overhaul is complete
exclude: ^(test/|core/dbt/docs/build/)

@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Jan 13, 2023
@ChenyuLInx ChenyuLInx merged commit 585e7c5 into main Jan 13, 2023
@ChenyuLInx ChenyuLInx deleted the cl/ref_override_tests_convert branch January 13, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants