Fix for dbt_project.yml "tests" config resulting in incorrect state:modified #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11166 +/- ##
==========================================
- Coverage 88.88% 88.84% -0.05%
==========================================
Files 187 187
Lines 24001 24011 +10
==========================================
- Hits 21334 21332 -2
- Misses 2667 2679 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aranke
approved these changes
Dec 18, 2024
| def test_unrendered_config(self, project): | ||
| manifest = run_dbt(["parse"]) | ||
| assert manifest | ||
| print(f"--- nodes: {manifest.nodes.keys()}") |
gshank
added a commit
that referenced
this pull request
Dec 19, 2024
…odified (#11166) (#11169) (cherry picked from commit bf18b59) Co-authored-by: Gerda Shank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11146
Problem
If the data_tests config in dbt_project.yml is named "tests", the unrendered_config for data tests is incorrect, resulting in incorrect state:modified results.
Solution
Rename the "tests" dictionary to "data_tests", so unrendered config is correctly generated.
Checklist