Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.9.latest] Warn if concurrent_batches config is set to True, but the available adapter doesn't support it #11154

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 6c61cb7 from #11145.

…le adapter doesn't support it (#11145)

* Begin producing warning when attempting to force concurrent batches without adapter support

Batches of microbatch models can be executed sequentially or concurrently. We try to figure out which to do intelligently. As part of that, we implemented an override, the model config `concurrent_batches`, to allow the user to bypass _some_ of our automatic detection. However, a user _cannot_ for batches to run concurrently if the adapter doesn't support concurrent batches (declaring support is opt in). Thus, if an adapter _doesn't_ support running batches concurrently, and a user tries to force concurrent execution via `concurrent_batches`, then we need to warn the user that that isn't happening.

* Add custom event type for warning about invalid `concurrent_batches` config

* Fire `InvalidConcurrentBatchesConfig` warning via `warn_or_error` so it can be silenced

(cherry picked from commit 6c61cb7)
@github-actions github-actions bot requested a review from a team as a code owner December 16, 2024 16:35
@cla-bot cla-bot bot added the cla:yes label Dec 16, 2024
@QMalcolm
Copy link
Contributor

For a sanity check, I pulled down the branch backport-11145-to-1.9.latest, and regenerated to proto just see if there were any differences via make core_proto_types. There were no differences, so we should be good 🙂

@QMalcolm
Copy link
Contributor

Closing and re-opening to get github actions to kick off properly

@QMalcolm QMalcolm closed this Dec 16, 2024
@QMalcolm QMalcolm reopened this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (dbd8ef3) to head (074fc74).
Report is 1 commits behind head on 1.9.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.9.latest   #11154      +/-   ##
==============================================
- Coverage       89.14%   89.08%   -0.07%     
==============================================
  Files             183      183              
  Lines           23857    23880      +23     
==============================================
+ Hits            21268    21273       +5     
- Misses           2589     2607      +18     
Flag Coverage Δ
integration 86.41% <100.00%> (-0.15%) ⬇️
unit 62.08% <94.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.08% <94.73%> (+0.01%) ⬆️
Integration Tests 86.41% <100.00%> (-0.15%) ⬇️

@QMalcolm QMalcolm merged commit 7fdd92f into 1.9.latest Dec 16, 2024
60 of 61 checks passed
@QMalcolm QMalcolm deleted the backport-11145-to-1.9.latest branch December 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant