Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix microbatch model PartialSuccess status to result in non-zero exit code #11115

Merged

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Dec 9, 2024

Resolves #11114

Problem

If run microbatch model resulted in a partial success, it didn't guarantee that there'd be a non-zero exit code, and this was problematic
Screenshot 2024-12-09 at 14 48 22

Solution

Update the interpret_results method to include PartialSuccess as being a failure state
Screenshot 2024-12-09 at 15 10 48

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm requested a review from a team as a code owner December 9, 2024 21:12
@cla-bot cla-bot bot added the cla:yes label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (03fdb4c) to head (ad566ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11115      +/-   ##
==========================================
- Coverage   88.96%   88.90%   -0.06%     
==========================================
  Files         183      183              
  Lines       23933    23933              
==========================================
- Hits        21291    21278      -13     
- Misses       2642     2655      +13     
Flag Coverage Δ
integration 86.20% <ø> (-0.14%) ⬇️
unit 61.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 61.96% <ø> (ø)
Integration Tests 86.20% <ø> (-0.14%) ⬇️

@QMalcolm QMalcolm changed the title Fx microbatch model PartialSuccess status to result in non-zero exit code Fix microbatch model PartialSuccess status to result in non-zero exit code Dec 9, 2024
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QMalcolm QMalcolm merged commit 983cbb4 into main Dec 10, 2024
55 of 56 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--11114-fix-microbatch-model-partial-success-exit-code branch December 10, 2024 15:48
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
…it code (#11115)

* Update partial success test to assert partial successes mean that the run failed

* Update results interpretation to include `PartialSuccess` as failure status

(cherry picked from commit 983cbb4)
QMalcolm added a commit that referenced this pull request Dec 10, 2024
…it code (#11115) (#11118)

* Update partial success test to assert partial successes mean that the run failed

* Update results interpretation to include `PartialSuccess` as failure status

(cherry picked from commit 983cbb4)

Co-authored-by: Quigley Malcolm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Partial success results in a 0 exit code, denoting success
2 participants