-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix microbatch model PartialSuccess
status to result in non-zero exit code
#11115
Merged
QMalcolm
merged 4 commits into
main
from
qmalcolm--11114-fix-microbatch-model-partial-success-exit-code
Dec 10, 2024
Merged
Fix microbatch model PartialSuccess
status to result in non-zero exit code
#11115
QMalcolm
merged 4 commits into
main
from
qmalcolm--11114-fix-microbatch-model-partial-success-exit-code
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11115 +/- ##
==========================================
- Coverage 88.96% 88.90% -0.06%
==========================================
Files 183 183
Lines 23933 23933
==========================================
- Hits 21291 21278 -13
- Misses 2642 2655 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
QMalcolm
changed the title
Fx microbatch model
Fix microbatch model Dec 9, 2024
PartialSuccess
status to result in non-zero exit codePartialSuccess
status to result in non-zero exit code
ChenyuLInx
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
QMalcolm
deleted the
qmalcolm--11114-fix-microbatch-model-partial-success-exit-code
branch
December 10, 2024 15:48
QMalcolm
added a commit
that referenced
this pull request
Dec 10, 2024
…it code (#11115) (#11118) * Update partial success test to assert partial successes mean that the run failed * Update results interpretation to include `PartialSuccess` as failure status (cherry picked from commit 983cbb4) Co-authored-by: Quigley Malcolm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11114
Problem
If run microbatch model resulted in a partial success, it didn't guarantee that there'd be a non-zero exit code, and this was problematic
Solution
Update the
interpret_results
method to includePartialSuccess
as being a failure stateChecklist