Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial parse yaml snapshots #10907

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Partial parse yaml snapshots #10907

merged 3 commits into from
Oct 23, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 23, 2024

Resolves #10903

Problem

All-yaml snapshot definitions are not handled by the existing snapshot schema file parsing code.

Solution

Handle removing snapshot nodes that are built without a SQL file.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner October 23, 2024 02:33
@cla-bot cla-bot bot added the cla:yes label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (f7b7935) to head (6653d02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10907      +/-   ##
==========================================
- Coverage   89.15%   86.54%   -2.62%     
==========================================
  Files         183      183              
  Lines       23443    23464      +21     
==========================================
- Hits        20901    20306     -595     
- Misses       2542     3158     +616     
Flag Coverage Δ
integration 86.54% <80.00%> (+0.10%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.54% <80.00%> (-2.62%) ⬇️
Integration Tests 86.54% <80.00%> (+0.10%) ⬆️

@gshank gshank merged commit bdb79e8 into main Oct 23, 2024
59 of 60 checks passed
@gshank gshank deleted the partial_parse_yaml_snapshots branch October 23, 2024 18:16
QMalcolm pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial parsing issues with all-yaml snapshot definition
2 participants