Update microbatch tests to handle update wherein incremental strategies are always validated #10884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are always validated dbt-adapters updated the incremental_strategy validation of incremental models such that the validation now _always_ happens when an incremental model is executed. A test in dbt-core `TestMicrobatchCustomUserStrategyEnvVarTrueInvalid` was previously set to _expect_ buggy behavior where an incremental model would succeed on it's "first"/"refresh" run even if it had an invalid incremental strategy. Thus we needed to update this test in dbt-core to expect the now correct behavior of incremental model execution time validation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10884 +/- ##
==========================================
- Coverage 89.21% 89.13% -0.08%
==========================================
Files 183 183
Lines 23443 23443
==========================================
- Hits 20914 20897 -17
- Misses 2529 2546 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ChenyuLInx
approved these changes
Oct 18, 2024
QMalcolm
added a commit
that referenced
this pull request
Oct 24, 2024
…es are always validated (#10884) dbt-adapters updated the incremental_strategy validation of incremental models such that the validation now _always_ happens when an incremental model is executed. A test in dbt-core `TestMicrobatchCustomUserStrategyEnvVarTrueInvalid` was previously set to _expect_ buggy behavior where an incremental model would succeed on it's "first"/"refresh" run even if it had an invalid incremental strategy. Thus we needed to update this test in dbt-core to expect the now correct behavior of incremental model execution time validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves N/A
Problem
A test broke because we fixed a bug in dbt-adapters (and the test depended on the bug 🙃)
Solution
Fix the test to work with the fixt dbt-adapters behavior
Checklist