-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy-First]: Fix timings
object for hooks and macros, and make types of timings explicit
#10882
Conversation
…es of timings explicit
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10882 +/- ##
==========================================
- Coverage 89.20% 89.15% -0.06%
==========================================
Files 183 183
Lines 23438 23443 +5
==========================================
- Hits 20909 20901 -8
- Misses 2529 2542 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -164,7 +164,7 @@ def test_use_custom_microbatch_strategy_env_var_true_invalid_incremental_strateg | |||
): | |||
# Initial run | |||
with patch_microbatch_end_time("2020-01-03 13:57:00"): | |||
run_dbt(["run"]) | |||
run_dbt(["run"], expect_pass=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is because the new dbt-adapters change altered the behavior here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.9.latest 1.9.latest
# Navigate to the new working tree
cd .worktrees/backport-1.9.latest
# Create a new branch
git switch --create backport-10882-to-1.9.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba6c7baf1d66d91fe7050e351e408e2a1186eee7
# Push it to GitHub
git push --set-upstream origin backport-10882-to-1.9.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.9.latest Then, create a pull request where the |
…es of timings explicit (#10882) * [Tidy-First]: Fix `timings` object for hooks and macros, and make types of timings explicit * cast literal to str * change test * change jsonschema to enum * Discard changes to schemas/dbt/manifest/v12.json * nits --------- Co-authored-by: Chenyu Li <[email protected]>
Disclaimer
test_use_custom_microbatch_strategy_env_var_true_invalid_incremental_strategy
is failing across all PRs, hence the test failuresProblem
timings
object accepts any arbitrary keys, scope this down to justcompile,
execute,
other`compile
andexecute
timings independently, but they do so combined right now.Solution
name
intimings
to be aLiteral
collect_timing_info
instead of creating aTimingInfo
object directlyChecklist