Ensure KeyboardInterrupt halts microbatch model execution
#10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to figure out how to test this. I think we can mock a function called during |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10879 +/- ##
==========================================
- Coverage 89.15% 89.09% -0.06%
==========================================
Files 183 183
Lines 23529 23531 +2
==========================================
- Hits 20977 20965 -12
- Misses 2552 2566 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…l execution Previously we were catching all execptions during microbatch model execution, and gracefully handling them. This ensured that one failing batch didn't cause the rest of the batches to fail / be skipped unnecessarily. However if there is a KeyboardInterrupt or SystemExit, execution should halt. To get this to happen, we're now catching and reraising `KeybaordInterrupts`s and `SystemExit`s.
QMalcolm
force-pushed
the
qmalcolm--10862-ensure-keyboard-interrupt-interrupts-microbatch-model-execution
branch
from
5c189ab to
e2869d5
Compare
ChenyuLInx
reviewed
Oct 30, 2024
| @@ -568,6 +568,9 @@ def _execute_microbatch_materialization( | |||
| # At least one batch has been inserted successfully! | |||
| incremental_batch = True | |||
|
|
|||
| except (KeyboardInterrupt, SystemExit): | |||
| # reraise it for GraphRunnableTask.execute_nodes to handle | |||
There was a problem hiding this comment.
Should we be writing out run results in this case?
There was a problem hiding this comment.
The KeyboardInterrupt handler in GraphRunnableTask.execute_nodes should handle it
ChenyuLInx
reviewed
Oct 30, 2024
ChenyuLInx
approved these changes
Oct 31, 2024
QMalcolm
deleted the
qmalcolm--10862-ensure-keyboard-interrupt-interrupts-microbatch-model-execution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10862
Problem
A
KeyboardInterruptduring the execution of microbatches would only cause the currently executing batch to stop, and then the rest of the batches (and job) would continue.Solution
Make
KeyboardInterrupts halt batch execution.Checklist