Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new validations for custom granularities #10789

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Sep 26, 2024

Resolves #9265

Description

Upgrade DSI version. This DSI version contains new validations for custom granularities that ensure unique naming. The custom granularity feature has not been released to customers yet, so new validations will not be breaking. Upgrading to this version in mantle will ensure that when the feature is released, customers will automatically get these validations.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Sep 26, 2024
@courtneyholcomb courtneyholcomb changed the title Release new validations for custom granularities Add new validations for custom granularities Sep 26, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review September 26, 2024 22:14
@courtneyholcomb courtneyholcomb requested a review from a team as a code owner September 26, 2024 22:14
@github-actions github-actions bot added the community This PR is from a community member label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (d8b1bf5) to head (1128dcd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10789   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files         183      183           
  Lines       23321    23321           
=======================================
  Hits        20790    20790           
  Misses       2531     2531           
Flag Coverage Δ
integration 86.44% <ø> (+<0.01%) ⬆️
unit 62.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.21% <ø> (ø)
Integration Tests 86.44% <ø> (+<0.01%) ⬆️

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@QMalcolm QMalcolm merged commit 5e3d418 into main Sep 27, 2024
68 checks passed
@QMalcolm QMalcolm deleted the court/custom-cal-val branch September 27, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3485] Semantic Layer custom calendar config support
2 participants