Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.8.latest] Global CLI flag should override env var flag #10427

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 601fee0 from #10423.

@github-actions github-actions bot requested a review from a team as a code owner July 10, 2024 19:26
@cla-bot cla-bot bot added the cla:yes label Jul 10, 2024
@gshank gshank closed this Jul 10, 2024
@gshank gshank reopened this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (d66c32a) to head (829a2dc).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10427      +/-   ##
==============================================
- Coverage       88.32%   88.29%   -0.03%     
==============================================
  Files             181      181              
  Lines           22767    22771       +4     
==============================================
- Hits            20108    20106       -2     
- Misses           2659     2665       +6     
Flag Coverage Δ
integration 85.55% <100.00%> (-0.05%) ⬇️
unit 62.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank merged commit 5d8b6aa into 1.8.latest Jul 12, 2024
68 checks passed
@gshank gshank deleted the backport-10423-to-1.8.latest branch July 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants