Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.2.latest] Fix #9907: Add retry to tox to reduce flaky tests due to network failures #10182

Merged
merged 1 commit into from
May 21, 2024
+17 −5
Merged

[Backport 1.2.latest] Fix #9907: Add retry to tox to reduce flaky tests due to network failures #10182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ jobs:
python -m pip install tox
tox --version

- name: Run tox
run: tox
- name: Run unit tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: tox -e unit

- name: Get current date
if: always()
Expand Down Expand Up @@ -166,8 +170,12 @@ jobs:
python -m pip install tox
tox --version

- name: Run tests
run: tox -- --ddtrace
- name: Run integration tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox -- --ddtrace

- name: Get current date
if: always()
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/structured-logging-schema-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ jobs:
# integration tests generate a ton of logs in different files. the next step will find them all.
# we actually care if these pass, because the normal test run doesn't usually include many json log outputs
- name: Run integration tests
run: tox -e integration -- -nauto
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox -e integration -- -nauto

- name: Archive code coverage results
uses: actions/upload-artifact@v4
Expand Down
Loading