-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent behavior change flag names + deprecation warnings #10063
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10063 +/- ##
==========================================
- Coverage 88.15% 88.14% -0.01%
==========================================
Files 181 181
Lines 22683 22700 +17
==========================================
+ Hits 19996 20009 +13
- Misses 2687 2691 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c7d8552
to
2d9f671
Compare
2d9f671
to
252b8d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some non-functional changes -- added documentation, updated changelog entry, reformatted the generated protos, and made the world's tiniest refactor.
The actual core changes here look great, thank you!
…t-behavior-change-flags
resolves #10062
Problem
Behavior change flags have inconsistent naming + use of the deprecations module for firing warnings.
Solution
Rename flags + use deprecations module, as described here (internal notion)
Checklist