[Backport 1.7.latest] convert SECRET_ENV_PREFIX from DBT_ENV_SECRET_ to DBT_ENV_SECRET

[emmyoop]

backports dbt-labs/dbt-common#110
relates to dbt-labs/dbt-common#109

Since that change is in dbt-common this is a manual implementation in a previous version.

Problem

DBT_ENV_SECRET_ is too strict with the final underscore.

Solution

Remove final underscore & update related docs (dbt-labs/docs.getdbt.com#5327) .

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (0322a4b) to head (9d4cfda).

Additional details and impacted files

@@              Coverage Diff               @@
##           1.7.latest   #10052      +/-   ##
==============================================
- Coverage       86.67%   86.64%   -0.03%     
==============================================
  Files             179      179              
  Lines           26662    26662              
==============================================
- Hits            23109    23102       -7     
- Misses           3553     3560       +7     

Flag	Coverage Δ
integration	83.47% <100.00%> (-0.03%)	⬇️
unit	65.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peterallenwebb]

looks good

[github-actions]

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-10052-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a54a4c04ba669517f18f2f9d3e6aea1656cba37
# Push it to GitHub
git push --set-upstream origin backport-10052-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-10052-to-1.6.latest.